fix: Fixes legend sync for standalone legend exit #136
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HrvojeHemen
approved these changes
Dec 12, 2025
pan-kot
force-pushed
the
experiment-sync-legends
branch
from
6cee7e8 to
e682fd8
Compare
pan-kot
commented
Dec 12, 2025
| this.chartExtraLegend.onClearHighlight(); | ||
|
|
||
| // Notify the consumer that a clear-highlight action was made. | ||
| fireNonCancelableEvent(this.context.handlers.onClearHighlight, { isApiCall: false }); |
Member
Author
There was a problem hiding this comment.
When a legend item highlight exits we call onClearChartItemsHighlight() to clear the chart's series highlight accordingly. However, we were not calling the onClearHighlight() in that case - which is a mistake.
SpyZzey
requested changes
Dec 12, 2025
Member
SpyZzey
left a comment
SpyZzey
left a comment
There was a problem hiding this comment.
There seems to be an infinite loop when hovering and unhovering the legend and charts:
pan-kot
force-pushed
the
experiment-sync-legends
branch
from
e682fd8 to
90910aa
Compare
Member
Author
Good catch! I fixed that in the page |
SpyZzey
previously approved these changes
Dec 12, 2025
pan-kot
force-pushed
the
experiment-sync-legends
branch
from
90910aa to
0cbb1b3
Compare
SpyZzey
approved these changes
Dec 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
An alternative for: #131
The PR introduces a new core test page that shows events synchronisation between standalone and in-chart legends, and includes a fix for the in-chart legend to call clear-highlight event on item highlight exit.
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.